admin/hspguard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: finish update service endpoint

Browse Source
This commit is contained in:
Amir Adal
2025-06-01 08:29:30 +02:00
parent bce775f692
commit dc2ce1f349
1 changed files with 29 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
internal/admin/apiservices.go
View File

@ -222,11 +222,11 @@ func (h *AdminHandler) RegenerateApiServiceSecret(w http.ResponseWriter, r *http
} }
type UpdateApiServiceRequest struct { type UpdateApiServiceRequest struct {
Name string `json:"name"` Name string `json:"name"`
Description string `json:"description"` Description string `json:"description"`
RedirectUris []string `json:"redirect_uris"` RedirectUris []string `json:"redirect_uris"`
Scopes []string `json:"scopes"` Scopes []string `json:"scopes"`
GrantTypes []string `json:"grant_types"` GrantTypes []string `json:"grant_types"`
} }
func (h *AdminHandler) UpdateApiService(w http.ResponseWriter, r *http.Request) { func (h *AdminHandler) UpdateApiService(w http.ResponseWriter, r *http.Request) {
@ -236,22 +236,22 @@ func (h *AdminHandler) UpdateApiService(w http.ResponseWriter, r *http.Request)
web.Error(w, "provided service id is not valid", http.StatusBadRequest) web.Error(w, "provided service id is not valid", http.StatusBadRequest)
return return
} }
var req UpdateApiServiceRequest var req UpdateApiServiceRequest
decoder := json.NewDecoder(r.Body) decoder := json.NewDecoder(r.Body)
if err := decoder.Decode(&req); err != nil { if err := decoder.Decode(&req); err != nil {
web.Error(w, "missing required fields to update service", http.StatusBadRequest) web.Error(w, "missing required fields to update service", http.StatusBadRequest)
return return
} }
if req.Name == "" { if req.Name == "" {
web.Error(w, "service name is required", http.StatusBadRequest) web.Error(w, "service name is required", http.StatusBadRequest)
return return
} }
if req.Description == "" { if len(req.Scopes) == 0 {
web.Error(w, "service name is required", http.StatusBadRequest) web.Error(w, "at least 1 scope is required", http.StatusBadRequest)
return return
} }
@ -260,16 +260,26 @@ func (h *AdminHandler) UpdateApiService(w http.ResponseWriter, r *http.Request)
web.Error(w, "service with provided id not found", http.StatusNotFound) web.Error(w, "service with provided id not found", http.StatusNotFound)
return return
} }
if err := h.repo.UpdateApiService(r.Context(), repository.UpdateApiServiceParams{ updated, err := h.repo.UpdateApiService(r.Context(), repository.UpdateApiServiceParams{
ClientID: service.ClientID, ClientID: service.ClientID,
Name: , Name: req.Name,
Description: pgtype.Text{}, Description: pgtype.Text{
RedirectUris: []string{}, String: req.Description,
Scopes: []string{}, Valid: true,
GrantTypes: []string{}, },
}); err != nil { RedirectUris: req.RedirectUris,
Scopes: req.Scopes,
GrantTypes: req.GrantTypes,
})
if err != nil {
web.Error(w, "failed to update api service", http.StatusInternalServerError) web.Error(w, "failed to update api service", http.StatusInternalServerError)
return return
} }
encoder := json.NewEncoder(w)
if err := encoder.Encode(NewApiServiceDTO(updated)); err != nil {
web.Error(w, "failed to send updated api service", http.StatusInternalServerError)
}
} }